Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error after upgrade to fish 3.1.0 on Ubuntu #17

Closed
wants to merge 1 commit into from
Closed

Fix error after upgrade to fish 3.1.0 on Ubuntu #17

wants to merge 1 commit into from

Conversation

fabiomargarido
Copy link

@fabiomargarido fabiomargarido commented Feb 13, 2020 •
edited
Loading

^ as a redirect to stderr was removed from fish 3.0.0. Weird that it only happened on Ubuntu after upgrading to 3.1.0...

Fixes #16.

@fabiomargarido
Fix error after upgrade to fish 3.1.0 on Ubuntu
ceee904 
`^` as a redirect to stderr was removed from fish 3.0.0. Weird that it only happened on Ubuntu after upgrading to 3.1.0...
@fabiomargarido fabiomargarido mentioned this pull request Feb 13, 2020
Open
@fabiomargarido
Copy link
Author

Hahaha the CI build fails because there's the same problem in another package:

Installing package default

~/.local/share/omf/pkg/omf/functions/bundle/omf.bundle.add.fish (line 11): Expected a string, but instead found a '&'

    if not grep $record $bundle > /dev/null ^&1

Guess this is going to take some time to sort out...

@fabiomargarido fabiomargarido mentioned this pull request Feb 14, 2020
Closed
@mwz
Copy link

mwz commented Feb 15, 2020

Don't you need to update fish version in the travis config (as it's currently on 2.2) and switch the omf channel to dev omf channel dev to get this working?

@derekstavis derekstavis mentioned this pull request Feb 17, 2020
Merged
@derekstavis
Copy link
Owner

Thanks for sending the pull request! I have incorporated this fix on #19, hence I'm closing this one.

@fabiomargarido fabiomargarido deleted the fix-3.1.0 branch February 17, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainLanz RomainLanz RomainLanz approved these changes

@derekstavis derekstavis derekstavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

init.fish (line 10): Expected a string, but instead found a '&'
4 participants
@fabiomargarido @mwz @derekstavis @RomainLanz