Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit data validation in FSR submissions to catch nil values throwing errors #95831

Open
7 of 16 tasks
penny-lischer opened this issue Oct 24, 2024 · 0 comments
Open
7 of 16 tasks
Assignees
Labels
backend unplanned-work Work that was not planned for during Sprint Planning vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2)

Comments

@penny-lischer
Copy link

penny-lischer commented Oct 24, 2024

Description

We have an issue with data being submitted to the transform code we've rolled out. After fixing the addressLine2, creditorName, and spouseFullName/last issues and adding error logging, there may be others that should be addressed before errors get thrown.

We need to fix these issues so veterans an continue to submit 5655's

In one instance, Andrew was able to verify that the frontend was setting a default string pre 'transform and submit'. Might be good to revisit the old FE implementation and see if they have use cases that we're missing.

Tasks

  • Audit the FE to see what fields had default values being set before the logic switch to BE
  • Add the default values to BE found in the audit that are missing
  • Add unit tests

Design and Front End sync on implementation of design

  • Required
  • Complete
  • Not Required

Acceptance criteria

  • no more errors for missing default values

Testing

  • N/A if non development work
  • Testing passed and documented in this ticket based off the "Then" statement in the description

Testing procedure:
If additional testing steps or credentials to perform testing are needed list them here


Ticket creation

Ticket requirements

Required to be "Ready"

  • Description written
  • Tasks defined
  • Acceptance criteria written
  • Testing defined
  • Add Labels
  • Attach to an Epic
  • Estimate Points
@penny-lischer penny-lischer added backend unplanned-work Work that was not planned for during Sprint Planning vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2) labels Oct 24, 2024
@penny-lischer penny-lischer self-assigned this Oct 24, 2024
@penny-lischer penny-lischer changed the title Copy of Issue with data validation in submission creditorName and spouseFullName/last [FSR] Audit data validation in FSR submissions to catch nil values throwing errors Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend unplanned-work Work that was not planned for during Sprint Planning vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2)
Projects
None yet
Development

No branches or pull requests

1 participant