Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno doc --html generating incorrect url reference in subpages #685

Open
RPDJF opened this issue Jan 1, 2025 · 0 comments
Open

deno doc --html generating incorrect url reference in subpages #685

RPDJF opened this issue Jan 1, 2025 · 0 comments

Comments

@RPDJF
Copy link

RPDJF commented Jan 1, 2025

This issue seems to correlate with this issue on deno: denoland/deno#25069

Link references on deno doc --html aren't correctly generated in subpages search queries, missing the base url

I have a production scenario where it doesn't work:

Actually hosting my doc through github pages (note that even simply opening index.html will result on same issue): https://rpdjf.github.io/Jikan.js/

Research on the man page works as expected, the links aren't broken:
https://rpdjf.github.io/Jikan.js/?q=jikanclient

But once we are on a subpage, like this:
https://rpdjf.github.io/Jikan.js/~/JikanClient.html

The research query will only display broken url references:
https://rpdjf.github.io/Jikan.js/~/JikanClient.html?q=animeManager

Now, when clicking on any of the search result, we end up with a 404 error, for example:
https://rpdjf.github.io/~/animeManager.html

These new research queries seems to remove the base url, returning:
https://rpdjf.github.io/~/animeManager.html instead of https://rpdjf.github.io/Jikan.js/~/animeManager.html

It seems like we lose the base url or something at some point

Using deno 2.1.4

Doc built with deno doc --html --name="Jikan.JS" .\src\v4\index.ts from root project folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant