Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error logging for duplicate host nqns #364

Merged
merged 15 commits into from
Oct 25, 2024
Merged

Error logging for duplicate host nqns #364

merged 15 commits into from
Oct 25, 2024

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Oct 24, 2024 •
edited
Loading

Description

Error logging for duplicate host nqns when found on the kubernetes nodes.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1530

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested on OCP cluster where duplicate host nqns were present in case of NVMe protocol. Error logged in that case.

@suryagupta4 suryagupta4 self-assigned this Oct 24, 2024
@suryagupta4 suryagupta4 marked this pull request as ready for review October 25, 2024 12:17
@suryagupta4 suryagupta4 merged commit 44479cf into main Oct 25, 2024
5 checks passed
@suryagupta4 suryagupta4 deleted the 1530_duplicate_hostnqn branch October 25, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhatdell rishabhatdell rishabhatdell approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

Assignees

@suryagupta4 suryagupta4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suryagupta4 @AkshaySainiDell @rishabhatdell