Simple server with database #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention that the server was built on ClearLinux. I don't guarantee that these steps would work nor on other OSs, neither on other distributions. |
|
@dikuchan I gave it a chance, but the "hello" wasn't delivered to me.
Also minor things:
My suggestions are:
Please discuss. |
veotani
requested changes
Jul 28, 2020
| use diesel::RunQueryDsl; | ||
| use actix_web::{web, HttpResponse}; | ||
|
|
||
| fn get_users(pool: web::Data<Pool>) -> Result<Vec<User>, diesel::result::Error> { |
There was a problem hiding this comment.
This is DAL method, it shouldn't be in API
| web, App, HttpServer, | ||
| middleware::Logger, | ||
| }; | ||
| use env_logger::Env; |
There was a problem hiding this comment.
Does it mean we already have loggin? If so, it should be documented somewhere.
| .route("/hello", web::get().to(api::auth::hello)) | ||
| .wrap(Logger::default()) | ||
| }) | ||
| .bind("localhost:8080")? |
There was a problem hiding this comment.
Should it be in config or not?
| Ok(items) | ||
| } | ||
|
|
||
| pub async fn hello(db: web::Data<Pool>) -> Result<HttpResponse, actix_web::Error> { |
There was a problem hiding this comment.
I would also like it to be in another package, not in auth. But it's up to you.
Open
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Actix as web framework and Diesel as ORM for Postgres.
In the current state, building procces is complicated and not automated. To successfuly build the server, reproduce next steps (would be useful for @FortyWays):
rustup(using official site, distro package, Docker or whatever).postgresql-devel(name depends on your distro) package in order for Diesel to link during linkage.DATABASE_URL. For example,Where username and password are the same as in the previous step, IP could be retrieved from Docker and name of the database is custom. Or, as an alternative, variable can be specified in
.envfile in thebackenddirectory.6. Run
cargo runin thebackenddirectory. It should successfuly compile and print that it started n workers and a service on localhost. For example,localhost:8080/hellohas status 200.Additionaly, you can fill the database with sample data. View table structure with DataGrid, for example, then add a new field. JSON response should return all fields in the table.