Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend API base path to include version information #73

Open
Kate-Lyndegaard opened this issue Feb 22, 2023 · 2 comments
Open

Extend API base path to include version information #73

Kate-Lyndegaard opened this issue Feb 22, 2023 · 2 comments
Labels
contributions welcome contributions are welcome feature New feature request

Comments

@Kate-Lyndegaard
Copy link

Kate-Lyndegaard commented Feb 22, 2023

Feature Description:

The URI of the API (base path) is extended to include the major version number, prefixed by the letter v.

A pull request is made so that this feature can be available as an optional extension to the core deegree OGC API product.

Additional information:

This issue is related to the Dutch API requirement labeled AP-20:

API-20: Include the major version number in the URI

The URI of an API (base path) must include the major version number, prefixed by the letter v. This allows the exploration of multiple versions of an API in the browser. The minor and patch version numbers are not part of the URI and may not have any impact on existing client implementations.

An example of a base path for an API with current version 1.0.2:

https://api.example.org/v1/

Definition of done:

The URI of an API (base path) includes the major version number, prefixed by the letter v.

A pull request including the functionality is made available to deegree OGC API.

The functionality is optional.

@Kate-Lyndegaard Kate-Lyndegaard added the feature New feature request label Feb 22, 2023
@tfr42 tfr42 added the contributions welcome contributions are welcome label Feb 22, 2023
@copierrj
Copy link
Member

copierrj commented Mar 8, 2023

The TMC discussed this feature request and has the following question:

While we do understand the need to add a version to a public url, we are not (yet) convinced that deegree should be aware of this. Wouldn't it be possible to use a reverse proxy / ingress controller to accomplish this?

@stempler
Copy link
Member

Please review the related Pull Request.

While we do understand the need to add a version to a public url, we are not (yet) convinced that deegree should be aware of this. Wouldn't it be possible to use a reverse proxy / ingress controller to accomplish this?

In our view arguments to include the functionality in deegree would be:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome contributions are welcome feature New feature request
Projects
None yet
Development

No branches or pull requests

4 participants