Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we overhaul internals of Variables #1104

Open
NickCrews opened this issue Sep 24, 2022 · 1 comment
Open

Can we overhaul internals of Variables #1104

NickCrews opened this issue Sep 24, 2022 · 1 comment

Comments

@NickCrews
Copy link
Contributor

@fgregg how open are you to backwards-incompatible changes to the way that Variables are implemented? If we could go in there and overhaul their APIs I think that might make #1102 be better. Not exactly sure what I'm looking for yet.

I'm thinking of if someone has gone and subclassed Variable then this might break them.

@fgregg
Copy link
Contributor

fgregg commented Sep 24, 2022

i'm open to big changes, but i doubt we need to make them breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants