Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make applyFirstValidOperation in Resolver return previous did state instead of undefined #981

Closed
isaacJChen opened this issue Dec 11, 2020 · 1 comment
Closed

Make applyFirstValidOperation in Resolver return previous did state instead of undefined #981

isaacJChen opened this issue Dec 11, 2020 · 1 comment
Labels
code refactoring

Comments

@isaacJChen
Copy link
Contributor

  • Make sure no side effects if this change is taken.
  • Make applyFirstValidOperation in Resolver return previous did state instead of undefined when no operation can be applied.
@thehenrytsai
Copy link
Collaborator

Closing this issue as won't fix.

Making the failure explicit is better than the current approach of inferring failure based on transaction number, it will also be more consistent with the pattern used downstream.

See also decentralized-identity/sidetree-reference-impl#6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thehenrytsai @isaacJChen