Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add di_vc and di_vp formats #8

Open
TimoGlastra opened this issue Dec 22, 2023 · 0 comments
Open

Add di_vc and di_vp formats #8

TimoGlastra opened this issue Dec 22, 2023 · 0 comments

Comments

@TimoGlastra
Copy link

TimoGlastra commented Dec 22, 2023

With the move towards the new data integrity vc spec (https://www.w3.org/TR/vc-data-integrity), it is now recommend to use DataIntegrityProof proof type.

This means that the actual crypt schema that is used is hidden, and thus the filter becomes a lot less useful.
Therefore I think it might be useful to register a new di_vc and di_vp claim format which define a new cryptosuite property:

{
    "^di_vc$|^di_vp$": {
      "type": "object",
      "additionalProperties": false,
      "properties": {
		// used for proof.type values (either DataIntegrityProof or custom one)
        "proof_type": {
          "type": "array",
          "minItems": 1,
          "items": { "type": "string" }
        },
  		// used for cryptosuite property of `DataIntegrityProof`, if `DataIntegrityProof` is include in `proof_type`)
        "cryptosuite": {
          "type": "array",
          "minItems": 1,
          "items": { "type": "string" }
        }
      }
    }
  }

An alternative would be to extend the ldp_vc and ldp_vp with an optional cryptosuite property that can be used if the DataIntegrityProof type is used:

{
    "^ldp_vc$|^ldp_vp$|^ldp$": {
      "type": "object",
      "additionalProperties": false,
      "properties": {
        "proof_type": {
          "type": "array",
          "minItems": 1,
          "items": { "type": "string" }
        },
       "cryptosuite": {
          "type": "array",
          "minItems": 1,
          "items": { "type": "string" }
       }
      }
    }
}

as data integrity is also the new name of the spec, it might be good to register the new di_vc either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant