Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate export/save as options with JupyterLab? #20

Open
krassowski opened this issue Feb 17, 2021 · 2 comments
Open

Integrate export/save as options with JupyterLab? #20

krassowski opened this issue Feb 17, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@krassowski
Copy link

The editor works really great here (including the save option).

I wonder if it would would be possible to add save as/export options so that the file can be saved to the current JupyterLab directory. Currently export to disk (this is download) does not work for me. Choosing:

Screenshot from 2021-02-17 14-34-45

and then:

Screenshot from 2021-02-17 14-35-06

Leads to:

Download is disallowed. The frame initiating or instantiating the download is sandboxed, but the flag ‘allow-downloads’ is not set. See https://www.chromestatus.com/feature/5706745674465280 for more details.

@krassowski krassowski added the enhancement New feature or request label Feb 17, 2021
@bollwyvl
Copy link

Somehow this had passed under my radar!

Anyhow, I guess I'm slightly missing some context (and I should make some .github templates!). Is this with:

  • a .dio(.svg|.png) Diagram document
  • a MimeRenderer/rich display
  • a Jupyter Widget

In a nutshell: it's found it hard to properly take away things from the drawio UI, and there is of course a lot of duplication between the Lab File Stuff and the Drawio File Stuff. There are a bunch of command palette commands for file actions for the Diagram... but none of these work for the other activities (like the Jupyter Widget).

Screenshot from 2021-04-09 21-03-43

Anyhow, I'll tag this as part of the 1.0.0 release plan (in the next week or so TBD), if you can fill in some of what you're looking for!

@bollwyvl bollwyvl added this to the 1.0.0 milestone Apr 10, 2021
@bollwyvl
Copy link

Still no headway on actually hiding that option (in a future-compatible way), but at least did add allow-downloads over on #22...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants