Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring Compatibility of JVM Arguments with Java 17 and 3rd Party Launchers #3

Open
913ms opened this issue Sep 2, 2024 · 0 comments

Comments

@913ms
Copy link

913ms commented Sep 2, 2024

I believe that the JVM arguments currently provided need to be fully compatible with Java 17, 11, and 21 as well as with more 3rd party launchers, including to Prism Launcher and others. I have found unrecognized VM options when using these JVM arguments with Java 17 and 21 across different launchers. This isn't good as it leads to performance issues crashes, and just outright not launching.

Fixes you can do

Update JVM Arguments
put some down for each java version

For Java 17
you could use something like this:

-XX:+UnlockExperimentalVMOptions -XX:+DisableExplicitGC -XX:+UseG1GC -XX:ParallelGCThreads=12 -XX:-UseGCOverheadLimit -Dfml.ignorePatchDiscrepancies=true -Dfml.ignoreInvalidMinecraftCertificates=true -XX:MaxGCPauseMillis=25 -XX:SurvivorRatio=8 -XX:TargetSurvivorRatio=90 -XX:MaxTenuringThreshold=15 -XX:SoftRefLRUPolicyMSPerMB=10000 -XX:ReservedCodeCacheSize=3072m -XX:+UseStringDeduplication

Update the README
Update the README to include JVM arguments and guides for Java 17, 11, 8, and 21.
Note it so that in launchers like Prism or MultiMC, the RAM arguments (e.g., -Xms and -Xmx) are not needed.

Create Guides for Multi Launchers Prism, At, and multimc
Give specific guides for different launchers, including 3rd party launchers like Prism and the normal Minecraft launcher, to to make more compatibility

This is a suggestion I wanted to make thats really it,
if you read this thank you and have a good day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@913ms and others