Consider altering xhprof_prepend.php at ddev xhgui time (and or ddev xhprof time) instead of start time

[rfay]

The current approach to altering xhprof_prepend.php is fine (in post-start hook), but I think it would be closer to the source if done by an overridden ddev xhprof or by ddev xhgui itself. Cleaning up would still have to be at stop with current architecture though, so that's an argument for keeping it the way it is.

[tyler36]

Is this still applicable since #48 was merged?

[rfay]

I think it might be, still thinking about it. Also, I think we should still think about a non-bind-mount strategy that simplifies programmatic replacement of this.

If xhgui goes directly into DDEV core, it would make sense to just have DDEV manage it and not worry about the direct config. However, that wouldn't be backward compatible, and there are plenty of people happy using xhprof as it currently is.