Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionBuilder.set_certs() does not work for native scripts #46

Open
siegfried opened this issue Apr 16, 2022 · 5 comments
Open

TransactionBuilder.set_certs() does not work for native scripts #46

siegfried opened this issue Apr 16, 2022 · 5 comments

Comments

@siegfried
Copy link
Contributor

siegfried commented Apr 16, 2022

When I call set_certs() with certificates generated from hashes of native scripts, it gives an error Uncaught RuntimeError: unreachable executed. I believe it is because this function only accepts Ed25519KeyHash.

@SebastienGllmt
Copy link
Contributor

This is partially handled in #45 but the refactoring required to support this isn't quite done yet

@siegfried
Copy link
Contributor Author

That would be great. Is there anything I can help to push this faster?

@siegfried
Copy link
Contributor Author

siegfried commented Apr 18, 2022

By a glance at the code I guess the refactoring required is to integrate the builders into TransactionBuilder? Is there any PR working on that? Do you need any help?

@SebastienGllmt
Copy link
Contributor

@siegfried unfortunately I have a lot of tooling work to do across projects, so it's hard to dedicate time to do rearchitectures of components unless we manage to grow the dcSpark tooling team. Maybe you know somebody interested in helping us fulltime?

@siegfried
Copy link
Contributor Author

siegfried commented Apr 18, 2022

Maybe you know somebody interested in helping us fulltime?

@SebastienGllmt Maybe I can help, by starting with this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants