Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Allow meta in semantic model entities #1604

Open
2 tasks done
siljamardla opened this issue Jan 16, 2025 · 0 comments
Open
2 tasks done

[Bug] Allow meta in semantic model entities #1604

siljamardla opened this issue Jan 16, 2025 · 0 comments
Labels
bug Something isn't working triage Tasks that need to be triaged

Comments

@siljamardla
Copy link

Is this a new bug in metricflow?

  • I believe this is a new bug in metricflow
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

It's a dbt standard that any configurations also take the meta key. In case of semantic model entities, this does not work.
For example

semantic_models:
  - name: dim_city
    description: City dimension
    model: ref('dim_city')
    entities:
      - name: city_id
        type: primary
        meta:
          state: live
      - name: country_id
        type: foreign

will result in the following error:

Parsing Error
  Invalid semantic_models config given in ... - at path ['entities'][0]: Additional properties are not allowed ('meta' was unexpected)

Expected Behavior

Meta should be supported to enable the governance that dbt usually enables. Sample use cases might include adding business knowledge about the entity, ownership, domains etc.

Steps To Reproduce

Try to add a meta key to an existing semantic model.

Relevant log output

Environment

- OS:
- Python:
- dbt:
- metricflow:

Which database are you using?

No response

Additional Context

No response

@siljamardla siljamardla added bug Something isn't working triage Tasks that need to be triaged labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Tasks that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant