Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Compatibility Issue with dbt-core 1.9.0 and dbt-metricflow 0.7.1 #1589

Closed
2 tasks done
mercedes-wu-wandb opened this issue Jan 7, 2025 · 2 comments
Closed
2 tasks done

[Bug] Compatibility Issue with dbt-core 1.9.0 and dbt-metricflow 0.7.1 #1589

mercedes-wu-wandb opened this issue Jan 7, 2025 · 2 comments
Labels
bug Something isn't working triage Tasks that need to be triaged

Comments

@mercedes-wu-wandb
Copy link

Is this a new bug in metricflow?

  • I believe this is a new bug in metricflow
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

I am not able to use cumulative_type_params in dbt-core 1.8.9 since it is a feature in dbt-core 1.9.0. However, when upgrading to 1.9.0 I am told that the latest version of dbt-metricflow (0.7.1) does not support it.

Expected Behavior

Compatibility between dbt-core 1.9.x and dbt-metricflow so newer paramters like cumulative_type_params are supported

Steps To Reproduce

  1. In an environment with dbt-metricflow set to 0.7.1
  2. Upgrade dbt-core to 1.9.0

Relevant log output

Because dbt-metricflow (0.7.1) depends on dbt-core (>=1.8.0,<1.9.0)
 and no versions of dbt-metricflow match >0.7.1,<0.8.0, dbt-metricflow (>=0.7.1,<0.8.0) requires dbt-core (>=1.8.0,<1.9.0).
So, because analytics depends on both dbt-metricflow (^0.7.1) and dbt-core (^1.9.1), version solving failed.

Environment

- OS: macOS Sonoma 14.7.2 (23H311)
- Python: Python 3.12.3
- dbt: 1.8.9 
- metricflow: 0.7.1

Which database are you using?

bigquery

Additional Context

No response
@mercedes-wu-wandb mercedes-wu-wandb added bug Something isn't working triage Tasks that need to be triaged labels Jan 7, 2025
@plypaul plypaul mentioned this issue Jan 25, 2025
Merged
plypaul added a commit that referenced this issue Jan 25, 2025
@plypaul
Release 0.207.1 (#1615)
78a0224 
Resolves #1589
Resolves #1632 

* The previous release `0.207.0` was not compatible with `dbt-core=1.9`
as the requirement for `dbt-semantic-interfaces` in both packages was
different.
* To address this, I've cut a branch `release-0.207.1` from commit
`5bb13511d36c6122527a1bd12de9d6e0707a9ddc`, which seems to be the last
version before the dependency requirement for `dbt-semantic-interfaces`
changed in `metricflow`.
* The requirement for `dbt-semantic-interfaces` was previously pinned to
`0.7.2` - I'm looking for context on the strict pin.
* For now, I've updated the requirement to
`dbt-semantic-interfaces>=0.7.4,<0.8`. `0.7.4` was the lowest version
compatible with `dbt-core=1.9`.
@plypaul
Copy link
Contributor

plypaul commented Jan 28, 2025

@mercedes-wu-wandb dbt-metricflow==0.8.0 has been released and addresses this issue.

@plypaul plypaul closed this as completed Jan 28, 2025
@mercedes-wu-wandb
Copy link
Author

thanks a ton @plypaul !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage Tasks that need to be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plypaul @mercedes-wu-wandb