Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding username with dynamic config #3

Open
davejlong opened this issue Jul 17, 2017 · 1 comment
Open

Allow overriding username with dynamic config #3

davejlong opened this issue Jul 17, 2017 · 1 comment

Comments

@davejlong
Copy link
Owner

Using the dynamic config API, we should enable overriding the VictorOps username value with a dynamic config.

Using a user layer, the VictorOps can be overridden from the default (Cog username) on a per user basis, as needed.

@davejlong
Copy link
Owner Author

This is a great task to introduce beginners to some Cog concepts. The only change to the code is at lib/cog_cmd/victor_ops/helpers.rb#L33. Instead of just using the Cog Username key, the code has to look for something like a VICTOROPS_USERNAME key in the ENV object.

The dynamic config would be something like:

VICTOROPS_USERNAME: dlong

Which would be deployed with cogctl bundle create --layer user/davejlong victorops ./victorops_davejlong.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant