Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubt about TSM temporal shift #8

Open
alejandrosatis opened this issue Jan 20, 2022 · 1 comment
Open

Doubt about TSM temporal shift #8

alejandrosatis opened this issue Jan 20, 2022 · 1 comment

Comments

@alejandrosatis
Copy link

Hi,

First of all, I'd like to congratulate about this repo, we've found this very useful. While training TSM, we've discovered that the parameter is_shift is by default false. Also, the import there cannot be resolved since the original make_temporal_shift code is not integrated into this repo.

Without is_shift enabled, does that mean that we're using a vanilla 2D Resnet50 and averaging the output of every input image in the sequence? Am I missing anything? The original contribution of TSM was this special temporal shift in the internal feature maps of any 2D CNN model.

Thanks in advance.

@zaidbhat1234
Copy link
Collaborator

Hey @alejandrosatis,

We are glad that you found this repo useful. Thanks for pointing out the issue. We have integrated the original make_temporal_shift and non_local code in the repo. Please let us know if this resolves your issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants