Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rtf conversion script with actual PDFs #135

Open
reginafcompton opened this issue Mar 19, 2018 · 6 comments
Open

Replace rtf conversion script with actual PDFs #135

reginafcompton opened this issue Mar 19, 2018 · 6 comments

Comments

@reginafcompton
Copy link
Contributor

The rtf conversion script for NYC sometimes requires longer than 15 minutes to complete (which delays NYC data imports).

Let's replace the RTF --> HTML with the actual PDFs. It should be possible via this PR.

@fgregg
Copy link
Member

fgregg commented Mar 20, 2018 via email

@reginafcompton
Copy link
Contributor Author

Can you say more about the "better web experience"?

For example, how does this NYC bill (HTML) compare with this Chicago bill (PDF)?

PDF cons
With the PDF, you need to scroll, if the bill has multiple pages; the PDF also looks rather small in mobile view.

HTML cons
With the HTML, we lose detail in the original bill document, which can make it difficult to read in the mobile view (see example above).

@fgregg
Copy link
Member

fgregg commented Mar 20, 2018 via email

@reginafcompton
Copy link
Contributor Author

Those are important points.

For details, we mainly lose header and footer information - so, nothing crucial. In that sense, it's an aesthetic issue. However, I still think for longer bills with several indents we sacrifice readability (particularly in the mobile view). I might be projecting my subjective experience though.

If we decide to maintain the rtf converter, then we must remember that it's imperfect: we should render PDFs as a "back-up" when a bill does not have html. But....would such inconsistently look strange for users?

@fgregg
Copy link
Member

fgregg commented Mar 20, 2018

We could render the footer and header.

@reginafcompton
Copy link
Contributor Author

I was able to speed up the RTF conversion script via datamade/django-councilmatic#230 (per issue #155).

We should still consider scraping the PDF links, but this seems like an enhancement to the current system. I will mark it as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants