Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_has_names fails on missing fft extension #282

Open
hameerabbasi opened this issue Jul 29, 2024 · 3 comments
Open

test_has_names fails on missing fft extension #282

hameerabbasi opened this issue Jul 29, 2024 · 3 comments

Comments

@hameerabbasi
Copy link
Contributor

I just got these failures updating to v2023.12 of the standard:

FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-fft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-ifft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-fftn] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-ifftn] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-rfft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-irfft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-rfftn] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-irfftn] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-hfft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-ihfft] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-fftfreq] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-rfftfreq] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-fftshift] - AttributeError: module 'sparse' has no attribute 'fft'
FAILED ../array-api-tests/array_api_tests/test_has_names.py::test_has_names[fft-ifftshift] - AttributeError: module 'sparse' has no attribute 'fft'

I'm on commit 827edd804bcace9d64176b8115138d29ae3e8dec.

@rgommers
Copy link
Member

rgommers commented Aug 5, 2024

I think if an extension module is not present, this should either give zero failures or a single failure that must be skipped in the skip file for the library under test.

Also, in case the decision on the above is "single failure", then it would be good to separate testing extensions out from test_has_names with a single test function per extension module, so that the skip can be done per missing extension.

@hameerabbasi
Copy link
Contributor Author

I've looked at the code; the intended behaviour is zero failures. However -- the code is obscured: A fix isn't straightforward.

@asmeurer
Copy link
Member

asmeurer commented Aug 7, 2024

This is just something that I forgot to test properly. The has_names test should automatically skip those tests if the test suite detects that the fft extension is not enabled. For now, you'll just need to skip those tests in your skips file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants