Only bundle assets and plugins from transitive closure of dependencies #160443
+1,120
−815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
sigurdm
force-pushed
the
only_bundle_assets_from_dependencies
branch
from
1024789 to
95ce951
Compare
sigurdm
changed the title
|
I think all local tests are passing now. (perhaps we should refactor some tests, so package_config.json doesn't have to be created uniquely for so many tests....) Not sure what happens in the customer tests, but I think it might be unrelated to this change. |
…from_dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/pub#4473
Fixes #79261
Fixes #160142
Fixes #155242
We could have used
pub depsto obtain the dependency graph, but given the fact that we already read all the pubspec.yaml files to gather assets, we might as well use those directly, and avoid a process invocation.Not sure if we should also bundle assets from dev_dependencies - not doing it might be breaking something - it would not be hard to change.