Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firehose] Should use the SDK specified in pubspec for validation #215

Open
dcharkes opened this issue Jan 3, 2024 · 0 comments
Open

[firehose] Should use the SDK specified in pubspec for validation #215

dcharkes opened this issue Jan 3, 2024 · 0 comments

Comments

@dcharkes
Copy link

dcharkes commented Jan 3, 2024

The SDK version can be specified for the firehose invocation:

https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose#publishing-from-a-specific-version-of-the-sdk

However, this doesn't work very well with mono repos, one might have a single package that tracks a dev version of the SDK.

Instead, firehose should use the version from the pubspec.

If that is technically impractical (due to the Dart SDK version being passed into some GitHub action setup), maybe we should have a best practice that we have a health configuration per package instead?

Context: Starting to track a dev branch of the Dart SDK for a single package in a mono repo:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant