Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt brain to Rocket Pool package #213

Open
dsimog01 opened this issue Mar 30, 2023 · 2 comments
Open

Adapt brain to Rocket Pool package #213

dsimog01 opened this issue Mar 30, 2023 · 2 comments
Labels
enhancement New feature or request P0 High priority

Comments

@dsimog01
Copy link
Contributor

In order to fit the needs of the new Rocket Pool Package, we need to perform the following changes:

  1. The fee recipient for RP validators should not be overridden in the brain, it should keep the one that is sent by the RP package (should we check it is actually that package the one sending the keystores?)
  2. The user should not be able to change the fee recipient from the brain (already done)
  3. The RP package should be able to change the fee recipient for a certain validator. We have two options for this:
    a. Allow the RP package to change the fee recipient by calling the updateValidators() function
    b. Allow the RP package to remove the keystores and upload them again with the new value for the fee recipient
@dsimog01 dsimog01 added enhancement New feature or request P0 High priority labels Mar 30, 2023
@pablomendezroyo
Copy link
Contributor

Sounds good!

The point that requires more development is 3. I would implement an API that would allow changing fee recipients in the brain database (which then will be persisted by the cron in the brain). I would also set this API endpoint to only edit Rocketpool fee recipients

My concerns are exposing this endpoint to the docker network, so any package would be allowed to do requests. Maybe a Host: rocketpool-goerli.dappnode would be a good start

@ujavid
Copy link

ujavid commented Jun 3, 2023

Would any solutions mentioned here solve this problem?:
#243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P0 High priority
Projects
None yet
Development

No branches or pull requests

3 participants