Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native docker compose merge functionality to merge compose properties #1983

Open
pablomendezroyo opened this issue Jul 10, 2024 · 0 comments

Comments

@pablomendezroyo
Copy link
Contributor

Right now the dappmanager edits a lot of stuff from the compose file when installing a new package, see packageInstall and setDappnodeComposeDefaults. This edit is done using utilities such as lodash. The requirements of the docker compose file are docker specific and relying on developers for the knowledge required to handle and implement this requirement does not make sense.

Instead, use the docker compose merge utility to merge properties set by dappmanager.

An example of usage would be the docker aliases, the docker aliases for a docker network must be unique otherwise there will be an error when handling this docker compose file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant