Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreadSanitizer: Swift access race #51

Open
fahidattique55 opened this issue Oct 30, 2018 · 5 comments
Open

ThreadSanitizer: Swift access race #51

fahidattique55 opened this issue Oct 30, 2018 · 5 comments

Comments

@fahidattique55
Copy link

Hey @danielrhodes

I am receiving swift access race while connecting socket. Please have a look into the Images below for more understanding.

screenshot 2018-10-30 at 5 52 13 pm

screenshot 2018-10-30 at 5 49 39 pm
@fahidattique55
Copy link
Author

@danielrhodes

I have created a merge request #52 for it. I have tested the code and it's not giving the swift race access issue after wrapping it under a sync queue. Please have a look into it and let me know if you need me for anything.

Thanks

@fahidattique55
Copy link
Author

Found some issue in #52 so don't merge that one. I have created another patch and its under testing. Once its complete then I will create a new merge request.

@fahidattique55
Copy link
Author

@danielrhodes Please see #53 my updated pull request which we have tested a lot.

@nerzh
Copy link

nerzh commented Aug 31, 2020

https://github.com/nerzh/Action-Cable-Swift

@fahidattique55
Copy link
Author

@nerzh you rock man 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nerzh @fahidattique55