Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In HTML, ID attributes may contain any character #24

Open
bertfrees opened this issue Jul 27, 2020 · 2 comments
Open

In HTML, ID attributes may contain any character #24

bertfrees opened this issue Jul 27, 2020 · 2 comments

Comments

@bertfrees
Copy link
Member

From the HTML specification:

When specified on HTML elements, the id attribute value must be unique amongst all the IDs in the element's tree and must contain at least one character. The value must not contain any ASCII whitespace.

[...]

There are no other restrictions on what form an ID can take; in particular, IDs can consist of just digits, start with a digit, start with an underscore, consist of just punctuation, etc.

This means that URL fragments are encoded. Pipeline currently does not take this into account when matching hyperlinks with elements.
@bertfrees
Copy link
Member Author

Note that this is not only an issue in braille.

@bertfrees bertfrees transferred this issue from daisy/pipeline-mod-braille Sep 9, 2020
@bertfrees bertfrees added this to the Next milestone Sep 9, 2020
bertfrees added a commit that referenced this issue Sep 15, 2020
@bertfrees
Fixes to generate-toc.xsl
cd195dd 
- The href attributes should start with #
- In HTML, id attributes may contain # or any other characters, so they
  need to be URL encoded when part of URL fragment (see
  #24)
bertfrees added a commit that referenced this issue Sep 15, 2020
@bertfrees
css:label-targets: support percent encoding in fragments
f7cf467 
see #24
@bertfrees
Copy link
Member Author

bertfrees commented Sep 15, 2020 •
edited
Loading

For braille: fixed in 9247acb and f7cf467

bertfrees added a commit that referenced this issue Sep 15, 2020
@bertfrees
Fixes to generate-toc.xsl
af2c0b3 
- The href attributes should start with #
- In HTML, id attributes may contain # or any other characters, so they
  need to be URL encoded when part of URL fragment (see
  #24)
bertfrees added a commit that referenced this issue Sep 15, 2020
@bertfrees
css:label-targets: support percent encoding in fragments
34f8754 
see #24
@bertfrees bertfrees removed this from the Next milestone Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bertfrees