Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile ads #110

Open
hongee opened this issue Jun 8, 2017 · 1 comment
Open

Fix mobile ads #110

hongee opened this issue Jun 8, 2017 · 1 comment

Comments

@hongee
Copy link
Collaborator

hongee commented Jun 8, 2017

Mobile ads are not loading - and shrinking the existing large banner ads are not possible.

Jeremy's reference implementation below

SITE: Daily Bruin Mobile
AD UNIT: Mobile Banner
AD SIZE(S): 320x50

<!--/* OpenX Asynchronous JavaScript tag */-->


<div id="538378860_INSERT_SLOT_ID_HERE" style="width:320px;height:50px;margin:0;padding:0">
  <noscript><iframe id="b301e745ca" name="b301e745ca" src="//oncampusweb-d.openx.net/w/1.0/afr?auid=538378860&cb=INSERT_RANDOM_NUMBER_HERE" frameborder="0" scrolling="no" width="320" height="50"><a href="//oncampusweb-d.openx.net/w/1.0/rc?cs=b301e745ca&cb=INSERT_RANDOM_NUMBER_HERE" ><img src="//oncampusweb-d.openx.net/w/1.0/ai?auid=538378860&cs=b301e745ca&cb=INSERT_RANDOM_NUMBER_HERE" border="0" alt=""></a></iframe></noscript>
</div>
<script type="text/javascript">
  var OX_ads = OX_ads || [];
  OX_ads.push({
     slot_id: "538378860_INSERT_SLOT_ID_HERE",
     auid: "538378860"
  });
</script>

<script type="text/javascript" src="//oncampusweb-d.openx.net/w/1.0/jstag"></script>
@zeehang
Copy link
Collaborator

zeehang commented Jun 14, 2017

Mobile ads are getting 3x the traffic - does that mean they're loading on desktop too and not getting displayed? Which doesn't make a ton of sense as the reverse should also be true?

http://mobiledetect.net/

We can look into using this to serve the correct ad size and not just load both and display one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants