Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why a different AbortController logic in 2.1.1? #45

Open
maikeriva opened this issue May 24, 2023 · 1 comment
Open

Why a different AbortController logic in 2.1.1? #45

maikeriva opened this issue May 24, 2023 · 1 comment

Comments

@maikeriva
Copy link

Hi Daishi Kato! Thanks for this handy hook :)

I'm diving into the code, and I'm struggling to understand the reasoning behind the modifications you did to the AbortController logic in 2.1.1 (commit f335dda) . I read in the changelog that they are related to some compatibility with React 18, can you be more explicit about that? It feels like there would be no need of an additional state variable for the AbortController, but obviously I am missing something as that was indeed the case before.

Thanks for any insights!

@dai-shi
Copy link
Owner

dai-shi commented May 24, 2023

#35 description might help. It didn't work with strict effect.

For more information: https://react.dev/reference/react/StrictMode#fixing-bugs-found-by-re-running-effects-in-development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants