-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selection.appendAll #301
Comments
Besides optimization, the benefit (as I understand it) would be a more straightforward expression of intent in that quite common case; a drawback might be that this new method doesn't allow the user to move from "create" to the "update" pattern if that's what they need. |
That's a great point. Migrating code that is designed to be run only once to code that can be run multiple times is one of the biggest pain points of D3 (in my experience at least, this is what students especially struggle with the most). Maybe the "update" pattern version of the shorthand could look something like this: one(svg, "g")
.joinAll("rect", data) shorthand for svg
.selectAll("g")
.data([null])
.join("g")
.selectAll()
.data(data)
.join("rect") |
Yes, that’s historically why D3 hasn’t included a special API for this case and encourages you to use selection.join instead. But I think it’s totally reasonable to special-case the enter selection, as people already do when they chain enter-append instead of using selection.join. |
What if this
were shorthand for this
The latter is a common special case of the data-join, and it seems worthwhile to support it explicitly? Some optimizations:
The text was updated successfully, but these errors were encountered: