Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run something like perltidy across the Cassandane sources #64

Open
elliefm opened this issue Sep 3, 2018 · 3 comments
Open

run something like perltidy across the Cassandane sources #64

elliefm opened this issue Sep 3, 2018 · 3 comments

Comments

@elliefm
Copy link
Contributor

elliefm commented Sep 3, 2018

The mixed tabs/spaces will shortly be changed to all spaces (using the Cyrus tools/remove-tabs.pl script). @rsto suggested on slack,

could we also apply some automated Perl formatting standard on the Cassandane modules? Especially the earlier JMAP cassandane tests used my standard vim perl intendation, and that looks really bad.

This seems like a good idea, but I'm not in a habit of using these tools so I don't simply have a configuration lying around.

@elliefm
Copy link
Contributor Author

elliefm commented Sep 3, 2018

Maybe @rjbs or @wolfsage have opinions about this sort of thing that they might like to share? :)

@wolfsage
Copy link
Contributor

wolfsage commented Sep 4, 2018

You'd think we would!

We both let our editors (or manually) style/indent our code I think.

But I think using something like perltidy is perfectly reasonable, we just would have to find a configuration everyone agrees on

@elliefm
Copy link
Contributor Author

elliefm commented Sep 5, 2018

I don't think we're talking about doing this regularly, just as a once-off sweep to make things consistentish. So IMO it's less about finding a configuration everyone agrees on, and more about finding a configuration that roughly approximates what we've already got (or at least: a configuration that already exists, so we can just get it done, without wasting months arguing over every byte of a new configuration).

Anyway it sounds like maybe such a configuration doesn't presently exist, so I'm happy to just handball this into the void!

(For whatever it's worth, I'm strongly against doing this on any more than an ad-hoc/occasional basis)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants