Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make :feature annotations also apply a minimum cyrus version requirement #63

Open
elliefm opened this issue Sep 3, 2018 · 0 comments
Open

Comments

@elliefm
Copy link
Contributor

elliefm commented Sep 3, 2018

We have a bunch of tests that are annotated with things like :Conversations to enable configuration to support testing that feature. These tests end up also needing to be annotated with something like :min_version_3_0 due to the feature in question not existing prior to then.

It'd be nice to have a way to associate feature annotations with versions, so that a :Conversations annotation is enough to both enable the feature for the test, and skip the test if the feature doesn't exist yet.

(There's a bunch of such annotations, I chose :Conversations here as a convenient example.)

elliefm added a commit that referenced this issue Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant