Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font used in pkgdown docs on cyncra.com (e.g. of the dm package) is blurry, at least in Edge and Firefox on Windows #45

Open
jranke opened this issue Jan 8, 2024 · 16 comments

Comments

@jranke
Copy link

jranke commented Jan 8, 2024

I only tested Edge and Firefox on Windows, but the font used in these browsers is blurry, which makes the documentation hard to read.

image

@maelle
Copy link
Member

maelle commented Jan 12, 2024

Thanks @jranke for reporting!

Do you see any error message in the Web Developer Console? See for instance https://firefox-source-docs.mozilla.org/devtools-user/web_console/ and https://firefox-source-docs.mozilla.org/devtools-user/web_console/console_messages/index.html

@jranke
Copy link
Author

jranke commented Jan 12, 2024

In firefox on Linux, as I am using right now it is fine. Will check the Web Developer Console next week on Windows and report back.

@maelle
Copy link
Member

maelle commented Jan 12, 2024

Good that you at least get a nice reading experience on Linux 😅 (I use Firefox on Ubuntu too!) Thank you!

@jranke
Copy link
Author

jranke commented Jan 12, 2024

For some reason it's partly fixed when viewing with Firefox on Windows now, but still some text is blurred, e.g. the version number and the word Author in the sidebar to the right.
image

I do get a couple of "Invalid property name" warnings in the CSS analysis window of the Developer Tools, e.g.
image
for the body tag of the page. But I do not know if this is related.

@jranke
Copy link
Author

jranke commented Jan 12, 2024

On edge, everything is still blurred
image

@maelle
Copy link
Member

maelle commented Jan 22, 2024

@jranke thank you! In the console part of the console (the icon near Elemente I think), are there error messages?

@jranke
Copy link
Author

jranke commented Jan 22, 2024

Yes, there are in fact error messages in Edge:

image

I would not think that they are related though.

@maelle
Copy link
Member

maelle commented Feb 12, 2024

@jranke I am so sorry for the delay! Does https://cynkratemplate.cynkra.com/ look better? Does https://cynkra.com look ok to you? I switched to using the same font rules as the main website.

@jranke
Copy link
Author

jranke commented Feb 13, 2024

Hi, https://cynkra.com looks nice in my Firefox on Windows, Edge does for some reason not work at the moment over here. The fonts on the cynkratemplate.com site look very basic, like arial or similar, but are definitely much more readable than https://dm.cynkra.com (all on Firefox at the moment).

@maelle
Copy link
Member

maelle commented Mar 4, 2024

@jranke note we're working on fonts, see #52 that hopefully will help. Thanks for your patience!

@talpitoo
Copy link
Collaborator

talpitoo commented Mar 4, 2024

@maelle although the work under https://github.com/cynkra/cynkraweb/issues/662 unifies the fonts usage technically, i haven't tested in Edge. With the new font setup the most important part is to stick to the existing font weights: 300, 400 and 700 because any other value would be rendered with the browser's faux styles. cc. @christophsax In case we notice a font issue, this is the first thing we need to check, just a FYI.

@jranke
Copy link
Author

jranke commented Jun 25, 2024

Just to add that https://dm.cynkra.com is still blurry on Windows (Edge and Firefox). Could it be that the firewall of Agroscope is preventing the availability of your font?

@talpitoo
Copy link
Collaborator

  1. After inspecting the network tab, i can verify that the correct fonts are not loaded on https://dm.cynkra.com/
  2. https://www.cynkra.com/ has the correct fonts, implemented here https://github.com/cynkra/cynkraweb/blob/main/www/user/_fonts.scss
  3. https://blog.cynkra.com/ has the correct fonts, implemented here https://github.com/cynkra/cynkratemplate/blob/main/inst/pkgdown/extra.scss#L1
  4. migrated the updated fonts solution from https://github.com/cynkra/cy… dm#2199 is still open
  5. correct URLs (to look for when verifying):

Screenshot from 2024-06-27 14-52-10
Screenshot from 2024-06-27 14-51-38
Screenshot from 2024-06-27 14-51-29

TL;DR i suspect the issue is because cynkra/dm#2199 is not merged. We might need devops help to resolve the failing build, cc. @maelle @christophsax

@maelle
Copy link
Member

maelle commented Sep 10, 2024

@talpitoo can you please remind me what the problem is?

@talpitoo
Copy link
Collaborator

@maelle please see the "TL;DR" in my previous comment. I am not sure if you can resolve that build issue in the PR, if not, we might need devops help to proceed with cynkra/dm#2199, cc. @christophsax

@maelle
Copy link
Member

maelle commented Sep 17, 2024

thanks for your patience 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants