Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve preview workflow #40

Closed
maelle opened this issue Jan 8, 2024 · 2 comments · Fixed by #41
Closed

improve preview workflow #40

maelle opened this issue Jan 8, 2024 · 2 comments · Fixed by #41

Comments

@maelle
Copy link
Member

maelle commented Jan 8, 2024

cc @pat-s

@pat-s
Copy link
Contributor

pat-s commented Jan 8, 2024

no longer use GitHub Pages?

No strong opinion. Both are fine (if you refer to S3 as the alternative).

quarto-dev/quarto-actions#96

Certainly an improvement, even though previews shouldn't stick around for so long that they get indexed and move up in the rankings. Shouldn't. But an option in the action would certainly be cool.

@maelle
Copy link
Member Author

maelle commented Jan 15, 2024

Certainly an improvement, even though previews shouldn't stick around for so long that they get indexed and move up in the rankings.

The thing is, if we keep using GitHub Pages, there'll always be a preview around, since the github.io website will be there all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants