Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Protector does not work with apps using config caching #96

Open
lupinitylabs opened this issue Nov 11, 2024 · 0 comments
Open

[Bug] Protector does not work with apps using config caching #96

lupinitylabs opened this issue Nov 11, 2024 · 0 comments

Comments

@lupinitylabs
Copy link
Member

In

return env($this->privateKeyName, '');
and
return $this->authToken ?: env($this->authTokenKeyName, '');
, Protector uses env() to read the keys, but on apps that have the configuration cached using config:cache, all calls to env() will return null.

To mitigate, Protector must ONLY read from the config, and set the defaults for the respective config keys using env() there. This has the drawback that the secrets will be cached, but that's a framework concept we cannot work around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant