New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x is missing an upgrade guide #89

Open

gael-connan-cybex opened this issue May 27, 2024 · 0 comments

Contributor

gael-connan-cybex commented May 27, 2024 •

edited

Loading

at least the error handling changes between 2.x and 3.x.

Document any required steps or possible effects in the readme file.

things to consider fixing in 3.x:

optimize imports, there are unused uses
remove commented uses as well
dont use generic exceptions. whoever uses this package should be able to catch all protector specific exceptions.
check if FailedCreatingDestinationPathException is still required, it doesnt seem to be used.
dont use small namespaces

lupinitylabs mentioned this issue

[3.1.0] Add Postgres Support #91

Merged

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment