Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up staking tests #330

Open
zxcat opened this issue Mar 23, 2020 · 0 comments
Open

Clean up staking tests #330

zxcat opened this issue Mar 23, 2020 · 0 comments

Comments

@zxcat
Copy link

zxcat commented Mar 23, 2020

Staking tests contain unused error messages:

const string can_not_be_negative = amsg("quantity can't be negative"); // !! didn't check. TODO: #330

const string nothing_to_cancel = amsg("nothing to cancel"); // !! didn't check. TODO: #330

static bool is_insufficient_ram_mssg(const std::string& arg) { // !! didn't check. TODO: #330

static bool is_costs_too_much_mssg(const std::string& arg) { // !! didn't check. TODO: #330

static bool is_system_err_mssg(const std::string& arg) { // !! didn't check (turned off). TODO: #330

static bool is_block_res_limit_err_mssg(const std::string& arg) { // !! didn't check. TODO: #330

etc… They should be removed if outdated or tests should be updated to use them.

Some checks are exist in the smart-contract, but didn't check in tests:

const string no_agent_exist(account_name agent) { // !! checked only in setinfo tests! TODO: #330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant