Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to error interception rather than length checking #127

Open
bnb opened this issue Jul 25, 2019 · 0 comments
Open

Move to error interception rather than length checking #127

bnb opened this issue Jul 25, 2019 · 0 comments

Comments

@bnb
Copy link
Member

bnb commented Jul 25, 2019

From #80 (comment):

If at this point we were to intercept an empty string literal from the response header rather than the results of a list, and this string literal was to be an error response in a short-circuit and no error was able to be parsed, edge of timeouts, parsing errors etc. This would still return as true, hence returning an empty string exposed.
It would be suitable at some point here validate the actual type integrity of the expected data formats being used, as side effects of this may lead to false positives.

Referring to bin/good-first-issue#32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant