Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No space between step keywords and step text in Korean dialect #237

Open
Likilee opened this issue Jun 25, 2024 · 1 comment
Open

No space between step keywords and step text in Korean dialect #237

Likilee opened this issue Jun 25, 2024 · 1 comment
Assignees
Labels
πŸ› bug Defect / Bug

Comments

@Likilee
Copy link

Likilee commented Jun 25, 2024

πŸ‘“ What did you see?

There is an issue where formatting in documents written in Korean causes the keywords and sentences to have no space between them.

βœ… What did you expect to see?

There should be a normal space between the formatted keywords and the sentences.

πŸ“¦ Which tool/library version are you using?

Vs-code extension

image

πŸ”¬ How could we reproduce it?

  1. Write a document(.feature) in Korean. (With #language: ko)
  2. Trigger format.
  3. Observe that there is no space between the formatted keyword and the sentence.

πŸ“š Any additional context?

Before formatting (What I exepected)

image

After formatting

image

@kieran-ryan
Copy link
Member

Thanks for flagging this @Likilee! This is an issue within the gherkin parser: a trailing space is missing on Korean step keywords. Thus, when the gherkin formatter parses your gherkin into a Cucumber messages format and writes back the changes, the step keywords and step text become joined.

Observe from the linked issue that I have raised a fix on the gherkin parser and we will have to await a release of the gherkin parser, cucumber language service and finally the Cucumber VSCode extension; but know that a fix is on its way!

@kieran-ryan kieran-ryan changed the title Formatting in Korean Documents Causes No Space Between Keywords and Sentences No space between step keywords and step text in Korean dialect Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Defect / Bug
Projects
None yet
Development

No branches or pull requests

2 participants