Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PhysFS? #31

Open
qwertychouskie opened this issue Apr 1, 2019 · 1 comment
Open

Switch to PhysFS? #31

qwertychouskie opened this issue Apr 1, 2019 · 1 comment
Assignees
Labels
T: Enhancement New feature or request

Comments

@qwertychouskie
Copy link
Member

Poco is currently disabled for Windows builds in my local working copy due to me having infinite headaches trying to get it to build for Windows and be included properly into Cubosphere. Also, Poco is very large, providing a lot of functionality not needed.

Enter PhysFS. (https://icculus.org/physfs/) From the description, it sounds like exactly what we need, and if we use it we would likely be able to get rid of most of filesystem.cpp, likely leaving only a few wrappers and helpers for the Lua scripts.

PhysFS seems to be kept reasonably up-to-date (there was a bugfix release in March of this year), and is used by many programs, including SuperTux.

What are your thoughts?

@qwertychouskie qwertychouskie added the T: Enhancement New feature or request label Apr 1, 2019
@qwertychouskie qwertychouskie changed the title Switch to PhysFS Switch to PhysFS? Apr 1, 2019
@v1993
Copy link
Member

v1993 commented Apr 2, 2019

@qwertychouskie Yeah, PhysFS is great library, I really like it. When working on from-scratch version I'll ceternaly use it.

If you'll replace it by yourself, I'll merge it. If not, that's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants