Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed contribution #2

Open
clmurphey opened this issue Nov 17, 2021 · 3 comments
Open

proposed contribution #2

clmurphey opened this issue Nov 17, 2021 · 3 comments

Comments

@clmurphey
Copy link
Collaborator

I completely misread the README.md and thought we were just supposed to put an issue in the community to which we are contributing. My apologies for the delay.

Comment on the SU2 Discussion board

I intend to contribute to SU2's VandV repository. Current examples are both out of date (last updated two years ago) and focus mostly on spatial convergence. My plan is to extend these examples to include a temporal convergence study using SU2's various built-in time integration methods. I may potentially extend this contribution to look at other time-integration methods and/or use PETSc to handle the time integration.

With Jordan Perr-Sauer, I may add an additional example related to wind farms. The idea is to include a benchmark problem executed with NALU with the same problem executed with SU2. Ideally, we will include a convergence study with Jordan focusing on spatial convergence and my contribution emphasizing temporal convergence methods.

I am still awaiting feedback on my contribution proposal.

@clmurphey clmurphey pinned this issue Nov 17, 2021
@clmurphey
Copy link
Collaborator Author

First portion of my contribution here. This portion is merely updating the configuration files and python wrappers within SU2's VandV repository.

@clmurphey
Copy link
Collaborator Author

clmurphey commented Dec 2, 2021

The second part of my contribution is currently under this branch. I need to make a few updates before submitting a pull request to SU2.

@clmurphey
Copy link
Collaborator Author

I changed directions a bit but I am much happier with the result.

I created a repository here with two examples including time convergence studies. Ideally, I would include more examples but I have been profoundly limited by the outputs from SU2. Some example problems just won't output the parameters I would like to look for convergence. I had some strange issues with boundary conditions, which may be due to my own ignorance or may be due to the modular nature of SU2 (some numerical methods and boundary conditions just don't work with certain "solvers" yet.)

I posted a link to this repository (with a brief explanation) on my original discussion post here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant