sync_table_2 regex does not properly escape a string replacement

[ChemiKyle]

redcapcustodian/R/write_data.R

Line 231 in a559cba

dplyr::rename_with(., ~ gsub(".x", "", .x), dplyr::ends_with(".x"))

The gsub call in this line treats . as a wildcard, not a literal . character.

To reproduce:

library(tidyverse)
library(redcapcustodian)

conn <- DBI::dbConnect(RSQLite::SQLite(), dbname = ":memory:")

table_names <- c(
  "redcap_projects"
)

for (table_name in table_names) {
  rcc.billing::create_and_load_test_table(
    table_name = table_name,
    conn = conn,
    load_test_data = T,
    is_sqllite = T
  )
}

redcap_projects <- tbl(conn, "redcap_projects") %>%
  collect()


updated_projects <- redcap_projects %>%
  mutate(status = 1)

# throws error
project_update_sync_activity <- sync_table_2(
  conn = rc_conn,
  table_name = "redcap_projects",
  source = updated_projects,
  source_pk = "project_id",
  target = redcap_projects,
  target_pk = "project_id"
)

# successful
project_update_sync_activity <- sync_table_2(
  conn = rc_conn,
  table_name = "redcap_projects",
  source = updated_projects %>%
    select(-contains("x")),
  source_pk = "project_id",
  target = redcap_projects,
  target_pk = "project_id"
)

---

Erroneous diagnosis:

redcapcustodian/R/write_data.R

Lines 246 to 251 in a559cba

	dbx::dbxUpdate(
	conn = conn,
	table = table_name,
	records = update_records,
	where_cols = target_pk
	)

While attempting to make an ETL, I've come across an odd limitation in sync_table_2 while investigating a failure to update redcap_projects. On my machine, update_records has a hard upper limit of 133 columns, at 134 I get Error: no such column:.