Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request_correction_of_bad_ownership_data.R is missing project designers #248

Open
pbchase opened this issue Aug 25, 2024 · 2 comments
Open
Assignees

Comments

@pbchase
Copy link
Contributor

pbchase commented Aug 25, 2024

request_correction_of_bad_ownership_data.R does not use role data to locate project designers who get permission via that path.

Consider refactoring request_correction_of_bad_ownership_data.R to use get_user_rights_and_info(). get_user_rights_and_info() hides the complexity of resolving permissions. It returns all the active permissions for every project. Use get_user_rights_and_info() instead of rcur at

project_contact_information <- rcur %>%

Then remove line 64, and remove unused objects at lines 25 and 26. That might be enough to fix the issue.

@pbchase
Copy link
Contributor Author

pbchase commented Jan 6, 2025

@ljwoodley Did you start on this one? I don't think it's urgent, but I thought we talked about this. Yet I can find no comment or PR that relates to it. I am confused

@ljwoodley
Copy link
Contributor

@ljwoodley Did you start on this one? I don't think it's urgent, but I thought we talked about this. Yet I can find no comment or PR that relates to it. I am confused

Yep, I started but did not finish before the break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants