Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two suggestions #27

Open
SilvanLaroo opened this issue Apr 21, 2017 · 0 comments
Open

Two suggestions #27

SilvanLaroo opened this issue Apr 21, 2017 · 0 comments
Labels

Comments

@SilvanLaroo
Copy link

Hi,

Thank you for this great module. I have two suggestions:

  • Can you make your private functions protected? This way I can override them from my own extension
  • In the Config file (CtiDigital\Configurator\Model\Component\Config) in the setConfig functions you skip existing values. But I want to set a config to NULL, now the check things that the value is already the same but it's not in the core_config_table yet. You should check if the value is available, like this: if ($value == $existingValue && $this->scopeConfig->isSetFlag($path, $scope)) {.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants