Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Peer Dependencies #47

Open
cristianoccazinsp opened this issue May 10, 2022 · 3 comments
Open

Update Peer Dependencies #47

cristianoccazinsp opened this issue May 10, 2022 · 3 comments

Comments

@cristianoccazinsp
Copy link
Contributor

Can you please update RN peer dependency so it matches any? Right now, we will get errors with the newest NPM and RN >= 0.67 because it is not listed as a dependency.

Thanks a lot!
@prometheas
Copy link
Collaborator

This is a good idea. Will try to find time to do this in the days ahead. Also, PRs welcome, if you've got time to get to it before I!

@cristianoccazinsp
Copy link
Contributor Author

@prometheas I would definitely push a PR, but I'm not sure what's the best approach to fix this since it's not documented what versions of RN this should support.

For me, I'm using RN 0.67 and it works fine, but I'm not sure whether or not you plan on still supporting RN 0.44 and older versions.

@cristianoccazinsp
Copy link
Contributor Author

https://github.com/csath/react-native-config-reader/pull/48/files

Take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prometheas @cristianoccazinsp