Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to add an Eventlistener for other events then warnings #89

Open
infeo opened this issue Aug 20, 2020 · 0 comments
Open

Add method to add an Eventlistener for other events then warnings #89

infeo opened this issue Aug 20, 2020 · 0 comments

Comments

@infeo
Copy link
Member

infeo commented Aug 20, 2020

Summary

Currently there is no way in cryptofs to continue on an event and notify the user about it. By extending the API to add an event listener, the caller can be notified without throwing an exception and stopping the current code execution.

Problem Description

In cryptofs there are cases where it would be good to inform the user caller about certain events/findings (e.g. files not belonging to the vault structure, invalid dir directories), without interrupting the current call and throw an error. This is not possible, and as a developer you need to decide to either ignore/log the event or throw an exception. From the caller perspective this is not the most desireable case, because with this you might miss (for you) important findings.

Solution

Expose in the API a method to add an eventlistener and then notify the listener on predefined events. The predefined events should be documented somewhere. For example there could be an extended method for filesystem creation, where one can hand over the event listener.

Alternatives

Collecting all occuring, not critical exceptions and then hand them over (in some way) to the caller. But this would require again some side channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant