Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSBT_TAP_KEY_SIG not supported #277

Open
pythcoiner opened this issue Jun 22, 2024 · 2 comments
Open

PSBT_TAP_KEY_SIG not supported #277

pythcoiner opened this issue Jun 22, 2024 · 2 comments

Comments

@pythcoiner
Copy link
Contributor

Signing w/ the taproot internal key looks not implemented, cf here

signing w/ taptree works fine, can be tested on liana w/ this PR
@stepansnigirev
Copy link
Collaborator

When signing with internal key, embit finalizes the input right away. So instead of adding the signature to tap key signature field it creates final witness.
But I agree, we should implement handling this field anyway

@pythcoiner
Copy link
Contributor Author

will have a look!

@pythcoiner pythcoiner mentioned this issue Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stepansnigirev @pythcoiner