Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread hanging on Client.dispose()/ Client.close() #7

Open
doriancransac opened this issue Nov 16, 2021 · 2 comments
Open

Thread hanging on Client.dispose()/ Client.close() #7

doriancransac opened this issue Nov 16, 2021 · 2 comments
Labels
PRs welcome Feel free to submit a PR for this type: bug Something isn't working

Comments

@doriancransac
Copy link

I noticed this issue over at EsotericSoftware /
kryonet : EsotericSoftware#142

and remembered that I spent quite a bit of time a few months ago trying to diagnose this, unsuccessfully. I'm curious if that's something that could be addressed on this forked repo in light of some of the info that was posted recently?

@crykn
Copy link
Owner

crykn commented Nov 16, 2021

I'm not using KryoNet much at the moment, but the most common suggestion seems to be to roll back EsotericSoftware@a7e9661 (see here, here and here). If it is confirmed that that works (on all platforms), it is a rather trivial change. Then we'd just need to figure out if this causes any other issues, in particular regarding EsotericSoftware#93, which was supposed to be fixed by the aforementioned commit.

@crykn crykn added type: bug Something isn't working PRs welcome Feel free to submit a PR for this labels Nov 16, 2021
@doriancransac
Copy link
Author

Hey, I totally understand, thanks for the quick feedback.

I'm personally not in a huge hurry to fix this so I won't try and patch it myself (I don't really have enough understanding of kryo to run proper regression tests anyways to submit a proper PR) but I thought it could make sense to at least mention this in case someone would be interested in testing & add the fix at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRs welcome Feel free to submit a PR for this type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants