Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings translations APIs: add new parameters support #166

Closed
andrii-bodnar opened this issue Oct 26, 2023 · 2 comments · Fixed by #168
Closed

Strings translations APIs: add new parameters support #166

andrii-bodnar opened this issue Oct 26, 2023 · 2 comments · Fixed by #168
Assignees
@soulshockers
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest

Comments

@andrii-bodnar
Copy link
Member

Several String Translation API endpoints have been enhanced with new parameters support: labelIds, excludeLabelIds. These parameters should be added to this API client.

References:
@andrii-bodnar andrii-bodnar added enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest labels Oct 26, 2023
@soulshockers
Copy link
Contributor

Hi! I would like to work on this.

soulshockers added a commit to soulshockers/crowdin-api-client-php that referenced this issue Oct 28, 2023
@soulshockers
feat: Strings translations APIs: add new parameters support crowdin#166
c5c50cb
@soulshockers
Copy link
Contributor

#168

@andrii-bodnar andrii-bodnar linked a pull request Oct 30, 2023 that will close this issue
feat: Strings translations APIs: add new parameters support #166 #168
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soulshockers soulshockers

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Strings translations APIs: add new parameters support #166 soulshockers/crowdin-api-client-php
2 participants
@soulshockers @andrii-bodnar