Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Make the generated file more explicit about their usage. (use a .gen.go extension) #220

Open
remyleone opened this issue Feb 2, 2022 · 5 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@remyleone
Copy link

What problem are you facing?

Having all files generated prefixed by zz_generated does not make it easier to understand what they are about when opened in a tree explorer.

How could Terrajet help solve your problem?

terrajet could generate files like .gen.go this convention is already followed by protobuf generator in go to make the distinction between generated files and hand written files.

@remyleone remyleone added the enhancement New feature or request label Feb 2, 2022
@muvaf
Copy link
Member

muvaf commented Feb 2, 2022

Hi @remyleone ! We're mostly following the convention of kubebuilder from upstream which uses that prefix for its generated files so that all generated files look similar 🙂

@remyleone
Copy link
Author

One thing that was not clear is whether or not those files should be kept as it or should they be renamed/edited. What happen if I need to update the jet-generated files? Maybe it would be helpful to add in the header of those generated files if they should be deleted/edited/renamed. In particular it could be really helpful to have a small description/documentation at the top of the files that explain what they mean. I'm not sure to understand what are the differences between deepcopy, managed, managedlist, terraform, and types.

@remyleone remyleone changed the title use a .gen.go extension Make the generated file more explicit about their usage. (use a .gen.go extension) Feb 2, 2022
@muvaf
Copy link
Member

muvaf commented Feb 3, 2022

Oh does that notice not appear in your generated files?

// Code generated by terrajet. DO NOT EDIT.

@remyleone
Copy link
Author

It does appear but I don't understand what this generated code does or the purpose it got. A bit of documentation about why those files are needed and how they work together and interact with the rest of the provider could be useful.

@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants