Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'policy.fromFieldPath: Required': spec.xxx: no such field #24

Open
haarchri opened this issue May 28, 2024 · 3 comments
Open

'policy.fromFieldPath: Required': spec.xxx: no such field #24

haarchri opened this issue May 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@haarchri
Copy link
Member

What happened?

So, we added the function-cel-filter after initially trying to use it embedded in function-patch-and-transform. Now, we're facing an issue where using function-cel-filter to filter resources causes required patches to fail in function-patch-and-transform, resulting in the XR getting READY: False.
Does anyone have an idea for a workaround for this behavior?

kubectl get xinit
NAME                     CROSSPLANE     SYNCED   READY   COMPOSITION               AGE
space-seed-j29p9-j8fq5   v1.15.2-up.1   True     False   xinit.spaces.upbound.io   13m
  Warning  ComposeResources         4m57s (x14 over 10m)  defined/compositeresourcedefinition.apiextensions.crossplane.io  Pipeline step "patch-and-transform": not adding new composed resource "external-dns-irsa" to desired state because "CombineFromComposite" patch at index 2 has 'policy.fromFieldPath: Required': spec.parameters.operators.externaldns: no such field

How can we reproduce it?

What environment did it happen in?

Function version:

@haarchri haarchri added the bug Something isn't working label May 28, 2024
@negz
Copy link
Member

negz commented May 28, 2024

Are you saying a patch from a required field fails if the CEL filter function prevents the required field from existing (e.g. by filtering the resource)? Or something else?

@haarchri
Copy link
Member Author

I filter resources using cel-filter, but this runs after P&T. This causes P&T to fail because some filtered resources have required fields that are not available.

@haarchri
Copy link
Member Author

let me add an reproducer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants