Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-restart to clone comand #19

Open
decentral1se opened this issue Mar 15, 2020 · 3 comments
Open

Add --no-restart to clone comand #19

decentral1se opened this issue Mar 15, 2020 · 3 comments

Comments

@decentral1se
Copy link
Contributor

We can avoid the following:

ps_rebuild "$APP"

This is useful for doing Ansible deployments where you want to control exactly at which point the app is deployed and not have it come up during some other configuration command.

@decentral1se
Copy link
Contributor Author

Please see #21.

@crisward
Copy link
Owner

Thanks for the suggestion and having a go, and more importantly testing. I'll leave this open, but I can't promise I'll get chance to look at it any time soon.

@ltalirz
Copy link

ltalirz commented Nov 8, 2020

I have a related request, which is: could we add a flag that makes dokku clone a no-op, if the git clone operation leaves the git checkout unchanged?

I notice that, currently, running dokku clone will rebuild the docker image and recreate the docker container even if the source code of the app hasn't changed at all.

P.S. If there was a way to make dokku clone a no-op in this case, it would simplify the implementation of the dokku_clone ansible module, since the module could then simply run dokku clone and rely on its internal logic to check whether anything needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants